Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customIRIs)!: custom IRIs must contain a UUID (DSP-1763) #1884

Merged
merged 10 commits into from Jun 29, 2021

Conversation

@SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Jun 24, 2021

resolves DSP-1763

@SepidehAlassi SepidehAlassi marked this pull request as ready for review Jun 28, 2021
@SepidehAlassi SepidehAlassi requested a review from subotic Jun 28, 2021
Copy link
Collaborator

@subotic subotic left a comment

LGTM, thanks! There are some open questions.

@subotic
Copy link
Collaborator

@subotic subotic commented Jun 29, 2021

@SepidehAlassi I forgot, could you please add a section in the documentation called something like "Breaking Changes / Migration Notes" where you can add a v14 subsection and add a short sentence to describe what is happening?

Don't forget: This commit needs to be merged with an exclamation mark (https://docs.dasch.swiss/developers/dsp/contribution/#type) to bump the version number to 14.

@SepidehAlassi SepidehAlassi merged commit 593d9cb into main Jun 29, 2021
11 checks passed
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1763_UUIDInCustomIRIs branch Jun 29, 2021
@SepidehAlassi SepidehAlassi changed the title feat(customIRIs): custom IRIs must contain a UUID (DSP-1763) feat!(customIRIs): custom IRIs must contain a UUID (DSP-1763) Jun 29, 2021
@SepidehAlassi SepidehAlassi changed the title feat!(customIRIs): custom IRIs must contain a UUID (DSP-1763) feat(customIRIs)!: custom IRIs must contain a UUID (DSP-1763) Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants