Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(projects)!: Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) #1886

Merged
merged 7 commits into from Jun 30, 2021
Merged

feat(projects)!: Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) #1886

merged 7 commits into from Jun 30, 2021

Conversation

SepidehAlassi
Copy link
Contributor

resolves DSP-1555

@SepidehAlassi SepidehAlassi self-assigned this Jun 28, 2021
@SepidehAlassi SepidehAlassi marked this pull request as ready for review June 28, 2021 17:07
@SepidehAlassi SepidehAlassi added API/Admin enhancement improve existing code or new feature labels Jun 28, 2021
@SepidehAlassi SepidehAlassi changed the title feat(projects): project shortname as xsd:NCName and escape special character in projects endpoints (DSP-1555 ) feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) Jun 28, 2021
@SepidehAlassi SepidehAlassi changed the title feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) feat!(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) Jun 29, 2021
@SepidehAlassi SepidehAlassi added the breaking any breaking change label Jun 29, 2021
@SepidehAlassi SepidehAlassi changed the title feat!(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) Jun 29, 2021
@SepidehAlassi SepidehAlassi removed the breaking any breaking change label Jun 29, 2021
@SepidehAlassi SepidehAlassi changed the title feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) feat!(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) Jun 30, 2021
@SepidehAlassi SepidehAlassi changed the title feat!(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) feat(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) Jun 30, 2021
subotic
subotic approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The commit message needs to have the exclamation mark after the parenthesis to trigger a bump in the major version.

@subotic subotic changed the title feat(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) feat(projects)!: Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) Jun 30, 2021
@subotic
Copy link
Collaborator

subotic commented Jun 30, 2021

@SepidehAlassi I forgot, could you maybe add a line to the migration notes?

@SepidehAlassi SepidehAlassi merged commit b3c2d5f into main Jun 30, 2021
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1555-escapeSpecialCharacterInProjectsEndpoint branch June 30, 2021 09:36
@daschbot daschbot mentioned this pull request Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees

@SepidehAlassi SepidehAlassi

Labels
API/Admin enhancement improve existing code or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SepidehAlassi @subotic