Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projects)!: Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) #1886

Merged

Conversation

@SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented Jun 28, 2021

resolves DSP-1555

@SepidehAlassi SepidehAlassi self-assigned this Jun 28, 2021
@SepidehAlassi SepidehAlassi marked this pull request as ready for review Jun 28, 2021
@SepidehAlassi SepidehAlassi changed the title feat(projects): project shortname as xsd:NCName and escape special character in projects endpoints (DSP-1555 ) feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) Jun 28, 2021
@SepidehAlassi SepidehAlassi changed the title feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) feat!(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) Jun 29, 2021
@SepidehAlassi SepidehAlassi requested a review from subotic Jun 29, 2021
@SepidehAlassi SepidehAlassi changed the title feat!(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) Jun 29, 2021
@SepidehAlassi SepidehAlassi changed the title feat(projects): project shortname as xsd:NCName and escape special character in payloads of projects endpoints (DSP-1555 ) feat!(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) Jun 30, 2021
@SepidehAlassi SepidehAlassi changed the title feat!(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) feat(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) Jun 30, 2021
Copy link
Collaborator

@subotic subotic left a comment

LGTM, thanks! The commit message needs to have the exclamation mark after the parenthesis to trigger a bump in the major version.

@subotic subotic changed the title feat(projects): Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) feat(projects)!: Change shortname to xsd:NCName forma, Escape special character in payloads of projects endpoints (DSP-1555 ) Jun 30, 2021
@subotic
Copy link
Collaborator

@subotic subotic commented Jun 30, 2021

@SepidehAlassi I forgot, could you maybe add a line to the migration notes?

@SepidehAlassi SepidehAlassi merged commit b3c2d5f into main Jun 30, 2021
11 checks passed
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1555-escapeSpecialCharacterInProjectsEndpoint branch Jun 30, 2021
@daschbot daschbot mentioned this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants