Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology V2): use internal iri when updating a property (DSP-1868) #1898

merged 7 commits into from Aug 19, 2021


Copy link

resolves DSP-1868

@irinaschubert irinaschubert marked this pull request as ready for review August 18, 2021 06:37
@irinaschubert irinaschubert requested review from BalduinLandolt and subotic and removed request for BalduinLandolt August 18, 2021 06:37
Copy link

Hi @subotic , in the end, we didn't manage to write a test to properly check the message creation but we testet the correct update behavior with the dsp-app (GUI) and the local Fuseki instance.

@subotic subotic changed the title fix(update-property): use internal iri when updating a property (DSP-1868) fix(ontology V2): use internal iri when updating a property (DSP-1868) Aug 18, 2021
Copy link

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, great work. LGTM!

@irinaschubert irinaschubert merged commit a746f65 into main Aug 19, 2021
@irinaschubert irinaschubert deleted the wip/DSP-1868-fix-update-property branch August 19, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants