Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology V2): use internal iri when updating a property (DSP-1868) #1898

Merged
merged 7 commits into from Aug 19, 2021

Conversation

@irinaschubert
Copy link
Contributor

@irinaschubert irinaschubert commented Aug 16, 2021

resolves DSP-1868

@irinaschubert irinaschubert marked this pull request as ready for review Aug 18, 2021
@irinaschubert irinaschubert requested review from BalduinLandolt and subotic and removed request for BalduinLandolt Aug 18, 2021
@irinaschubert
Copy link
Contributor Author

@irinaschubert irinaschubert commented Aug 18, 2021

Hi @subotic , in the end, we didn't manage to write a test to properly check the message creation but we testet the correct update behavior with the dsp-app (GUI) and the local Fuseki instance.

@subotic subotic changed the title fix(update-property): use internal iri when updating a property (DSP-1868) fix(ontology V2): use internal iri when updating a property (DSP-1868) Aug 18, 2021
Copy link
Collaborator

@subotic subotic left a comment

cool, great work. LGTM!

@irinaschubert irinaschubert merged commit a746f65 into main Aug 19, 2021
11 checks passed
@irinaschubert irinaschubert deleted the wip/DSP-1868-fix-update-property branch Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants