Repository navigation
refactor(ontology)!: use patch instead of delete for deleting cardinalities (DSP-1700) - #1903
Merged
irinaschubert merged 9 commits intoSep 14, 2021
Conversation
irinaschubert
changed the title
irinaschubert
changed the title
Author
|
Hi @subotic , I used PATCH instead of DELETE for the deletion of cardinalities (PUT was already in use). It seems that PATCh wasn't used before so I had to enable it and also adjust the tests for these methods. I assigned the PR to you just that you can see what I did. You don't need to review it as you are on holidays. |
irinaschubert
marked this pull request as ready for review
September 13, 2021 08:28
kilchenmann
changed the title
…-cardinalities-from-class
BalduinLandolt
approved these changes
Sep 13, 2021
added 2 commits
September 14, 2021 12:11
…-cardinalities-from-class
irinaschubert
deleted the
wip/DSP-1700-put-instead-delete-for-deleting-cardinalities-from-class
branch
September 14, 2021 12:13
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DSP-1700