Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ontology)!: use patch instead of delete for deleting cardinalities (DSP-1700) #1903

Conversation

@irinaschubert
Copy link
Contributor

@irinaschubert irinaschubert commented Sep 8, 2021

resolves DSP-1700

@irinaschubert irinaschubert self-assigned this Sep 8, 2021
@irinaschubert irinaschubert changed the title use put instead of delete for deleting cardinalities refactor!: use put instead of delete for deleting cardinalities (DSP-1700) Sep 8, 2021
@irinaschubert irinaschubert changed the title refactor!: use put instead of delete for deleting cardinalities (DSP-1700) refactor!: use patch instead of delete for deleting cardinalities (DSP-1700) Sep 8, 2021
@irinaschubert
Copy link
Contributor Author

@irinaschubert irinaschubert commented Sep 9, 2021

Hi @subotic , I used PATCH instead of DELETE for the deletion of cardinalities (PUT was already in use). It seems that PATCh wasn't used before so I had to enable it and also adjust the tests for these methods. I assigned the PR to you just that you can see what I did. You don't need to review it as you are on holidays.

@irinaschubert irinaschubert marked this pull request as ready for review Sep 13, 2021
@kilchenmann kilchenmann changed the title refactor!: use patch instead of delete for deleting cardinalities (DSP-1700) refactor(ontology)!: use patch instead of delete for deleting cardinalities (DSP-1700) Sep 13, 2021
Copy link
Collaborator

@kilchenmann kilchenmann left a comment

LGTM. Thank you

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

looks good to me

@irinaschubert irinaschubert merged commit 91ef4ec into main Sep 14, 2021
11 checks passed
@irinaschubert irinaschubert deleted the wip/DSP-1700-put-instead-delete-for-deleting-cardinalities-from-class branch Sep 14, 2021
@daschbot daschbot mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants