Repository navigation
docs: add username to changeable attributes (DSP-1895) - #1904
Conversation
| status: Option[Boolean] = None, | ||
| systemAdmin: Option[Boolean] = None) { | ||
| * Represents an API request payload that asks the Knora API server to update an existing user. Information that can | ||
| * be changed include the user's username, email, given name, family name, language, password, user status, and system admin |
There was a problem hiding this comment.
This is the only change I've done in this file. The rest is reformatting.
| val iriEquals = identifier.toIriOption.contains(id) | ||
| val emailEquals = identifier.toEmailOption.contains(email) | ||
| val usernameEquals = identifier.toUsernameOption.contains(username) |
There was a problem hiding this comment.
Although most of re-formatting done in the file makes sense, the one marked above I don't personally like and it's kind of the same "alignment idea" to arguments formatted here before. I opt to keep fields as it was before :)
There was a problem hiding this comment.
OK, I suggest that we do the reformatting in a separate PR and then reformat everything (we already tried that but then the tests didn't run through - so we need to be careful with this). Besides, I don't know how to re-do this now... (as it was done automatically by saving the file)
There was a problem hiding this comment.
It's matter of the formatter configuration. It should be rather easy to revert unwanted things.
mpro7
left a comment
mpro7
left a comment
There was a problem hiding this comment.
As we agreed, we need to agree on the formatting rules etc. until then we should avoid reformat the code, but in this single file we can have it as a reference, which will be adjusted soon.
3 participants
resolves DSP-1895