Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add username to changeable attributes (DSP-1895) #1904

Merged
merged 3 commits into from Sep 13, 2021

Conversation

@irinaschubert
Copy link
Contributor

@irinaschubert irinaschubert commented Sep 8, 2021

resolves DSP-1895

@irinaschubert irinaschubert self-assigned this Sep 8, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Sep 8, 2021
status: Option[Boolean] = None,
systemAdmin: Option[Boolean] = None) {
* Represents an API request payload that asks the Knora API server to update an existing user. Information that can
* be changed include the user's username, email, given name, family name, language, password, user status, and system admin
Copy link
Contributor Author

@irinaschubert irinaschubert Sep 8, 2021

This is the only change I've done in this file. The rest is reformatting.

val iriEquals = identifier.toIriOption.contains(id)
val emailEquals = identifier.toEmailOption.contains(email)
val usernameEquals = identifier.toUsernameOption.contains(username)
Copy link
Contributor

@mpro7 mpro7 Sep 9, 2021

Although most of re-formatting done in the file makes sense, the one marked above I don't personally like and it's kind of the same "alignment idea" to arguments formatted here before. I opt to keep fields as it was before :)

Copy link
Contributor Author

@irinaschubert irinaschubert Sep 9, 2021

OK, I suggest that we do the reformatting in a separate PR and then reformat everything (we already tried that but then the tests didn't run through - so we need to be careful with this). Besides, I don't know how to re-do this now... (as it was done automatically by saving the file)

Copy link
Contributor

@mpro7 mpro7 Sep 9, 2021

It's matter of the formatter configuration. It should be rather easy to revert unwanted things.

@irinaschubert irinaschubert requested a review from mpro7 Sep 13, 2021
mpro7
mpro7 approved these changes Sep 13, 2021
Copy link
Contributor

@mpro7 mpro7 left a comment

As we agreed, we need to agree on the formatting rules etc. until then we should avoid reformat the code, but in this single file we can have it as a reference, which will be adjusted soon.

@irinaschubert irinaschubert merged commit 719cd0d into main Sep 13, 2021
11 checks passed
@irinaschubert irinaschubert deleted the wip/DSP-1895-fix-documentation branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants