Repository navigation
fix(candeletecardinalities): return correct response on route negative case (DEV-36) - #1910
Conversation
mpro7
changed the title
mpro7
changed the title
irinaschubert
left a comment
irinaschubert
left a comment
There was a problem hiding this comment.
I like the removal of duplicated code. Did you test if it is working? Because there is now a new clientTestDataCollector created in each call of CollectClientTestData(...). Before, it was one clientTestDataCollector for all the tests in this file. Do we still get all test data in the end?
| // Collects client test data | ||
| private val clientTestDataCollector = new ClientTestDataCollector(settings) | ||
| // TODO: redefine below method somewhere else if can be reused over other test files | ||
| private def CollectClientTestData(filename: String, payload: String) = { |
There was a problem hiding this comment.
| private def CollectClientTestData(filename: String, payload: String) = { | |
| private def collectClientTestData(filename: String, filecontent: String) = { |
There was a problem hiding this comment.
@irinaschubert at the end it's both payload and the file content ;) but in the matter of consistency I accept this suggestion.
val clientTestDataCollector = new ClientTestDataCollector(settings) can be also defined outside the method, maybe this is better performance wise. Everything was working well, but I think that some tests failed after that commit 2d9c26d where we added 3 missing test data.
|
|
||
| // Collects client test data | ||
| // TODO: redefine below method somewhere else if can be reused over other test files | ||
| private def CollectClientTestData(fileName: String, fileContent: String): Unit = |
3 participants
resolves DEV-36