Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(knora-base): fix typo #1918

Merged
merged 1 commit into from Oct 12, 2021
Merged

chore(knora-base): fix typo #1918

merged 1 commit into from Oct 12, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Oct 8, 2021

There was a typo in the german label of "region is part of"

@kilchenmann kilchenmann self-assigned this Oct 8, 2021
@mpro7 mpro7 changed the title chore(knora-base): fix typo test(knora-base): fix typo Oct 8, 2021
@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 12, 2021

@mpro7 why did you changed the title to "test"? The typo occurs in the knora-base ontology which is part of the system and not only of the tests.

Loading

@kilchenmann kilchenmann requested review from mpro7 and subotic Oct 12, 2021
@mpro7
Copy link
Contributor

@mpro7 mpro7 commented Oct 12, 2021

@kilchenmann because I've noticed the change in two SPEC and TTL files, assuming thet these are tests files and test data. If I'm wrong bring it back.

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Oct 12, 2021

@kilchenmann because I've noticed the change in two SPEC and TTL files, assuming thet these are tests files and test data. If I'm wrong bring it back.

Yes, I had to adapt the test files after editing the knora base ontology.

Loading

@kilchenmann kilchenmann changed the title test(knora-base): fix typo chore(knora-base): fix typo Oct 12, 2021
@kilchenmann kilchenmann merged commit 720aa65 into main Oct 12, 2021
11 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/fix-typo-in-region branch Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants