Repository navigation
fix: removing cardinality of a link property (DEV-90) - #1919
Merged
Merged
Conversation
mpro7
approved these changes
Oct 11, 2021
Comment on lines
958
to
960
| internalClassDef = internalClassDef, | ||
| allBaseClassIris = allBaseClassIris.toSet, | ||
| cacheData = cacheData |
Contributor
There was a problem hiding this comment.
I think this could be simplified:
.checkCardinalitiesBeforeAddingAndIfNecessaryAddLinkValueProperties(
internalClassDef,
allBaseClassIris.toSet,
cacheData,
...
irinaschubert
approved these changes
Oct 11, 2021
| ) // turn the propertyIri into a ReadPropertyInfoV2 | ||
| .filter(_.isLinkProp) // we are only interested in link properties | ||
| .map(_.entityInfoContent.propertyIri) // turn whatever is left back to a propertyIri | ||
| ) |
There was a problem hiding this comment.
I don't understand why this has to be done
Collaborator
Author
There was a problem hiding this comment.
the data model for links consist of the linked property and a corresponding link property value. This checkCardinalitiesBeforeAddingAndIfNecessaryAddLinkValueProperties method will complain if there are already link property values defined, because this method should add them. This is why this method has the existingLinkPropsToKeep parameter. Since this parameter only takes IRIs we first need to convert all property IRIs to ReadPropertyInfoV2 then filter out anything that is not a link property and then turn it back to a property IRI.
…c.scala Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…c.scala Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…c.scala Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-90