Repository navigation
fix(groups): update test data and documentation to use language specific group descriptions (DEV-123) - #1921
Merged
irinaschubert merged 9 commits intoOct 14, 2021
Conversation
irinaschubert
marked this pull request as ready for review
October 13, 2021 07:53
subotic
reviewed
Oct 13, 2021
subotic
left a comment
subotic
left a comment
Collaborator
There was a problem hiding this comment.
What shall we do with existing groups on the test, staging and production server ?
mpro7
approved these changes
Oct 14, 2021
irinaschubert
deleted the
wip/DEV-123-fix-test-data-and-documentation-groups
branch
October 14, 2021 15:44
kilchenmann
reviewed
Nov 9, 2021
Comment on lines
-54
to
+57
| "description": "NewGroupDescription", | ||
| "descriptions": [ | ||
| {"value": "NewGroupDescription", "language": "en"}, | ||
| {"value": "NeueGruppenBeschreibung", "language": "de"} | ||
| ], |
Contributor
There was a problem hiding this comment.
Just a comment: In fact this is a breaking change. But groups endpoint is not used yet (at least in dsp-app) but already implemented in js-lib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-123