Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groups): update test data and documentation to use language specific group descriptions (DEV-123) #1921

Merged

Conversation

@irinaschubert
Copy link
Contributor

@irinaschubert irinaschubert commented Oct 13, 2021

resolves DEV-123

@irinaschubert irinaschubert self-assigned this Oct 13, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Oct 13, 2021
@irinaschubert irinaschubert requested review from mpro7 and subotic Oct 13, 2021
Copy link
Collaborator

@subotic subotic left a comment

What shall we do with existing groups on the test, staging and production server ?

Loading

@irinaschubert irinaschubert requested a review from subotic Oct 13, 2021
Copy link
Collaborator

@subotic subotic left a comment

LGTM

Loading

mpro7
mpro7 approved these changes Oct 14, 2021
@irinaschubert irinaschubert merged commit 0f45b51 into main Oct 14, 2021
11 checks passed
Loading
@irinaschubert irinaschubert deleted the wip/DEV-123-fix-test-data-and-documentation-groups branch Oct 14, 2021
"description": "NewGroupDescription",
"descriptions": [
{"value": "NewGroupDescription", "language": "en"},
{"value": "NeueGruppenBeschreibung", "language": "de"}
],
Copy link
Collaborator

@kilchenmann kilchenmann Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment: In fact this is a breaking change. But groups endpoint is not used yet (at least in dsp-app) but already implemented in js-lib.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants