Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump sipi version (DEV-188) #1931

Merged
merged 13 commits into from Nov 3, 2021
Merged

Conversation

@subotic
Copy link
Collaborator

@subotic subotic commented Nov 1, 2021

resolves DEV-188

@subotic subotic self-assigned this Nov 1, 2021
@subotic subotic requested a review from BalduinLandolt Nov 1, 2021
@subotic
Copy link
Collaborator Author

@subotic subotic commented Nov 1, 2021

@BalduinLandolt the changed LUA files are relevant for your BundleRepresentation PR. We need to clean this up. The distinctions there are a bit confusing.

Loading

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

I could see us needing more changes to the lua scripts. But for now, this looks good

Loading

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Loading

@subotic subotic merged commit d302b5e into main Nov 3, 2021
12 checks passed
Loading
@subotic subotic deleted the wip/DEV-188-use-smaller-sipi-image branch Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants