Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(lists+groups): improve value objects + remove new lists implementation (DEV-160) #1932

Merged
merged 28 commits into from Nov 17, 2021

Conversation

@mpro7
Copy link
Contributor

@mpro7 mpro7 commented Nov 3, 2021

resolves DEV-160 + removes new lists route implementation. Some functionalities were moved to old one, the documentation was updated too.

@mpro7 mpro7 requested a review from subotic as a code owner Nov 3, 2021
@mpro7 mpro7 self-assigned this Nov 3, 2021
@mpro7 mpro7 marked this pull request as draft Nov 3, 2021
@mpro7 mpro7 marked this pull request as ready for review Nov 5, 2021
@mpro7 mpro7 marked this pull request as draft Nov 5, 2021
@mpro7 mpro7 marked this pull request as ready for review Nov 12, 2021
@mpro7 mpro7 changed the title Wip/dev 160 refactor(listsADM/groupsADM): improve value objects implementation + remove new lists (DEV-160) Nov 12, 2021
@@ -29,38 +29,11 @@ test-data/admin/lists/delete-list-response.json
test-data/admin/lists/get-anything-project-lists-response.json
test-data/admin/lists/get-image-project-lists-response.json
test-data/admin/lists/get-list-info-response.json
test-data/admin/lists/get-list-node-info-response.json
Copy link
Collaborator

@kilchenmann kilchenmann Nov 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test-data-file is now missing in js-lib. What was the reason to delete the file?

Loading

Copy link
Collaborator

@kilchenmann kilchenmann Nov 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what will be the equivalent test-data for all the deleted "feature_toggle" lists?

Loading

Copy link
Contributor Author

@mpro7 mpro7 Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test data are generated in relation to E2E tests on DSP-API side, if the test was deleted, the test data file needs to be deleted too. In this case, the test was redundant. In the case of lists - whole new implementation is gone, so the related tests and test-data are.

Loading

@mpro7 mpro7 changed the title refactor(listsADM/groupsADM): improve value objects implementation + remove new lists (DEV-160) refactor(lists+groups): improve value objects implementation + remove new lists (DEV-160) Nov 16, 2021
@mpro7 mpro7 changed the title refactor(lists+groups): improve value objects implementation + remove new lists (DEV-160) refactor(lists+groups): improve value objects + remove new lists implementation (DEV-160) Nov 16, 2021
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Nov 16, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

Loading

@mpro7 mpro7 merged commit 24e34dd into main Nov 17, 2021
11 of 12 checks passed
Loading
@mpro7 mpro7 deleted the wip/DEV-160 branch Nov 17, 2021
@mpro7 mpro7 changed the title refactor(lists+groups): improve value objects + remove new lists implementation (DEV-160) refactor!(lists+groups): improve value objects + remove new lists implementation (DEV-160) Nov 18, 2021
@mpro7 mpro7 mentioned this pull request Nov 18, 2021
mpro7 added a commit that referenced this issue Nov 18, 2021
…lementation (DEV-160) (#1932)

* refactor group create payload

* separate group route value object

* add group iri value object

* use project IRI in group create patload + add group value object error messages &  test

* updated groups value objects and tests

* add value objects to groups update payload

* move optional params to value objects + replace either by zio.Validation

* refactor(list): replace Either with zio.Validation + move option to value objects

* refactor projectIri value object

* fix node creation

* add validation to payloads creation in lists and groups

* remove doubled checks and related tests

* disable new list route + separate NodeApiRequestADM to root & child

* list route factory + new list route implementation

* refactor list naming

* make parentNodeIri required for ListChildNodeCreatePayloadADM

* fix tests

* refactor lists get methods

* update lists docs

* fix update single lists properties + groups cleanup

* fix client-test-data

* bring back GET methods

* fix file extension

* fix testdata
mpro7 added a commit that referenced this issue Nov 19, 2021
* refactor!(lists+groups): improve value objects + remove new lists implementation (DEV-160) (#1932)

* refactor group create payload

* separate group route value object

* add group iri value object

* use project IRI in group create patload + add group value object error messages &  test

* updated groups value objects and tests

* add value objects to groups update payload

* move optional params to value objects + replace either by zio.Validation

* refactor(list): replace Either with zio.Validation + move option to value objects

* refactor projectIri value object

* fix node creation

* add validation to payloads creation in lists and groups

* remove doubled checks and related tests

* disable new list route + separate NodeApiRequestADM to root & child

* list route factory + new list route implementation

* refactor list naming

* make parentNodeIri required for ListChildNodeCreatePayloadADM

* fix tests

* refactor lists get methods

* update lists docs

* fix update single lists properties + groups cleanup

* fix client-test-data

* bring back GET methods

* fix file extension

* fix testdata

* fix(userADM): diable catche for get methods

* fix: replace invalidateCachedProjectADM with CacheServiceFlushDB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants