refactor!(lists+groups): improve value objects + remove new lists implementation (DEV-160) #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpro7
changed the title
kilchenmann
reviewed
Nov 14, 2021
| @@ -29,38 +29,11 @@ test-data/admin/lists/delete-list-response.json | |||
| test-data/admin/lists/get-anything-project-lists-response.json | |||
| test-data/admin/lists/get-image-project-lists-response.json | |||
| test-data/admin/lists/get-list-info-response.json | |||
| test-data/admin/lists/get-list-node-info-response.json | |||
There was a problem hiding this comment.
This test-data-file is now missing in js-lib. What was the reason to delete the file?
There was a problem hiding this comment.
And what will be the equivalent test-data for all the deleted "feature_toggle" lists?
There was a problem hiding this comment.
Test data are generated in relation to E2E tests on DSP-API side, if the test was deleted, the test data file needs to be deleted too. In this case, the test was redundant. In the case of lists - whole new implementation is gone, so the related tests and test-data are.
mpro7
changed the title
mpro7
changed the title
|
SonarCloud Quality Gate failed.
|
subotic
approved these changes
Nov 17, 2021
mpro7
changed the title
Closed
mpro7
added a commit
that referenced
this pull request
Nov 18, 2021
…lementation (DEV-160) (#1932) * refactor group create payload * separate group route value object * add group iri value object * use project IRI in group create patload + add group value object error messages & test * updated groups value objects and tests * add value objects to groups update payload * move optional params to value objects + replace either by zio.Validation * refactor(list): replace Either with zio.Validation + move option to value objects * refactor projectIri value object * fix node creation * add validation to payloads creation in lists and groups * remove doubled checks and related tests * disable new list route + separate NodeApiRequestADM to root & child * list route factory + new list route implementation * refactor list naming * make parentNodeIri required for ListChildNodeCreatePayloadADM * fix tests * refactor lists get methods * update lists docs * fix update single lists properties + groups cleanup * fix client-test-data * bring back GET methods * fix file extension * fix testdata
mpro7
added a commit
that referenced
this pull request
Nov 19, 2021
* refactor!(lists+groups): improve value objects + remove new lists implementation (DEV-160) (#1932) * refactor group create payload * separate group route value object * add group iri value object * use project IRI in group create patload + add group value object error messages & test * updated groups value objects and tests * add value objects to groups update payload * move optional params to value objects + replace either by zio.Validation * refactor(list): replace Either with zio.Validation + move option to value objects * refactor projectIri value object * fix node creation * add validation to payloads creation in lists and groups * remove doubled checks and related tests * disable new list route + separate NodeApiRequestADM to root & child * list route factory + new list route implementation * refactor list naming * make parentNodeIri required for ListChildNodeCreatePayloadADM * fix tests * refactor lists get methods * update lists docs * fix update single lists properties + groups cleanup * fix client-test-data * bring back GET methods * fix file extension * fix testdata * fix(userADM): diable catche for get methods * fix: replace invalidateCachedProjectADM with CacheServiceFlushDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-160 + removes new lists route implementation. Some functionalities were moved to old one, the documentation was updated too.