Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projectsADM): clear cache after changing project (DEV-239) #1943

Merged
merged 4 commits into from Nov 19, 2021
Merged

Conversation

@mpro7
Copy link
Contributor

@mpro7 mpro7 commented Nov 18, 2021

resolves DEV-239 + rebase last commit message

mpro7 added 2 commits Nov 18, 2021
…lementation (DEV-160) (#1932)

* refactor group create payload

* separate group route value object

* add group iri value object

* use project IRI in group create patload + add group value object error messages &  test

* updated groups value objects and tests

* add value objects to groups update payload

* move optional params to value objects + replace either by zio.Validation

* refactor(list): replace Either with zio.Validation + move option to value objects

* refactor projectIri value object

* fix node creation

* add validation to payloads creation in lists and groups

* remove doubled checks and related tests

* disable new list route + separate NodeApiRequestADM to root & child

* list route factory + new list route implementation

* refactor list naming

* make parentNodeIri required for ListChildNodeCreatePayloadADM

* fix tests

* refactor lists get methods

* update lists docs

* fix update single lists properties + groups cleanup

* fix client-test-data

* bring back GET methods

* fix file extension

* fix testdata
@mpro7 mpro7 self-assigned this Nov 18, 2021
@mpro7 mpro7 requested a review from subotic as a code owner Nov 18, 2021
@mpro7 mpro7 changed the title Wip/dev 239 fix(userADM): disable catching for GET single user methods (DEV-239) Nov 18, 2021
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Nov 19, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Loading

@mpro7 mpro7 changed the title fix(userADM): disable catching for GET single user methods (DEV-239) fix(projectsADM): clear cache after changing project (DEV-239) Nov 19, 2021
@mpro7 mpro7 merged commit 17c5c09 into main Nov 19, 2021
11 of 12 checks passed
Loading
@mpro7 mpro7 deleted the wip/DEV-239 branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants