Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology): cardinality of one can be added to classes as long as not used in data #1958

Merged
merged 8 commits into from Dec 14, 2021

Conversation

@irinaschubert
Copy link
Contributor

@irinaschubert irinaschubert commented Dec 6, 2021

resolves DEV-233

It is now possible to add a cardinality to a class even if it has a subclass. This is only allowed if that class or any sub-class (recursively) is not yet used in data, i.e. has no resource instantiated from it. Therefore I added a new check isClassUsedInData.

@irinaschubert irinaschubert self-assigned this Dec 6, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Dec 7, 2021
@irinaschubert irinaschubert requested a review from subotic as a code owner Dec 7, 2021
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

looks good

mpro7
mpro7 approved these changes Dec 8, 2021
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@irinaschubert irinaschubert merged commit 2cebac7 into main Dec 14, 2021
13 checks passed
@irinaschubert irinaschubert deleted the wip/dev-233-superclass-cardinality branch Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants