Repository navigation
fix(candeletecardinalities): return canDoResponse of false instead of throwing an exception for inherited cardinalities (DEV-314) - #1966
Merged
irinaschubert merged 10 commits intoDec 16, 2021
Conversation
irinaschubert
changed the title
irinaschubert
marked this pull request as ready for review
December 15, 2021 07:29
subotic
approved these changes
Dec 15, 2021
added 2 commits
December 15, 2021 15:03
|
Kudos, SonarCloud Quality Gate passed!
|
BalduinLandolt
approved these changes
Dec 16, 2021
BalduinLandolt
left a comment
BalduinLandolt
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just to minor remarks that you can feel free to implement or ignore.
Plus maybe reconsider the PR title scope to be more on the module level.
irinaschubert
deleted the
wip/dev-314-candeletecardinalities-on-inherited-properties
branch
December 16, 2021 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-314