Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(candeletecardinalities): return canDoResponse of false instead of throwing an exception for inherited cardinalities (DEV-314) #1966

Merged

Conversation

@irinaschubert
Copy link
Contributor

@irinaschubert irinaschubert commented Dec 14, 2021

resolves DEV-314

@irinaschubert irinaschubert self-assigned this Dec 14, 2021
@irinaschubert irinaschubert changed the title fix(candeletecardinalities): return canDoResponse of false instead of throwing an exception (DEV-314) fix(candeletecardinalities): return canDoResponse of false instead of throwing an exception for inherited cardinalities (DEV-314) Dec 14, 2021
@irinaschubert irinaschubert marked this pull request as ready for review Dec 15, 2021
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Dec 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
61.5% 61.5% Duplication

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Looks good. Just to minor remarks that you can feel free to implement or ignore.
Plus maybe reconsider the PR title scope to be more on the module level.

@irinaschubert irinaschubert merged commit 55b5d4b into main Dec 16, 2021
13 checks passed
@irinaschubert irinaschubert deleted the wip/dev-314-candeletecardinalities-on-inherited-properties branch Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants