refactor(admin): refactor projects & users value objects (DEV-240) #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpro7
changed the title
mpro7
changed the title
There was a problem hiding this comment.
I added some suggestions, nothing very important (and I've always only added it the first time I saw something, so you need to check for other occurrences if you agree with the suggestion).
Something that is not clear to me: for value objects, why do we need 2 make() methods again?
...n/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsMessagesADM.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADM.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADM.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADM.scala
Show resolved
Hide resolved
...n/scala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/UsersResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/admin/UsersRouteADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/admin/UsersRouteADM.scala
Show resolved
Hide resolved
...ala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADMSpec.scala
Outdated
Show resolved
Hide resolved
...ala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADMSpec.scala
Show resolved
Hide resolved
BalduinLandolt
approved these changes
Jan 13, 2022
...la/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsErrorMessagesADM.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsMessagesADM.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/knora/webapi/messages/admin/responder/usersmessages/UsersPayloadsADM.scala
Show resolved
Hide resolved
...n/scala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADM.scala
Show resolved
Hide resolved
...n/scala/org/knora/webapi/messages/admin/responder/valueObjects/ProjectsValueObjectsADM.scala
Show resolved
Hide resolved
subotic
approved these changes
Jan 14, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-240