Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(admin): refactor projects & users value objects (DEV-240) #1976

Merged
merged 22 commits into from Jan 14, 2022
Merged

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Jan 6, 2022

resolves DEV-240

@mpro7 mpro7 self-assigned this Jan 6, 2022
@mpro7 mpro7 requested a review from subotic as a code owner Jan 6, 2022
@mpro7 mpro7 marked this pull request as draft Jan 6, 2022
@mpro7 mpro7 changed the title refactor(userADM): user create payload refactor(userADM/projectADM): refactor value objects Jan 12, 2022
@mpro7 mpro7 marked this pull request as ready for review Jan 12, 2022
@mpro7 mpro7 changed the title refactor(userADM/projectADM): refactor value objects refactor(admin): refactor projects & users value objects (DEV-240) Jan 12, 2022
Copy link
Collaborator

@irinaschubert irinaschubert left a comment

I added some suggestions, nothing very important (and I've always only added it the first time I saw something, so you need to check for other occurrences if you agree with the suggestion).
Something that is not clear to me: for value objects, why do we need 2 make() methods again?

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

@mpro7 mpro7 merged commit 563d252 into main Jan 14, 2022
13 checks passed
@mpro7 mpro7 deleted the wip/DEV-240 branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants