Repository navigation
refactor(admin): refactor projects & users value objects (DEV-240) - #1976
Merged
Merged
Conversation
mpro7
changed the title
mpro7
marked this pull request as ready for review
January 12, 2022 16:59
mpro7
changed the title
irinaschubert
left a comment
irinaschubert
left a comment
There was a problem hiding this comment.
I added some suggestions, nothing very important (and I've always only added it the first time I saw something, so you need to check for other occurrences if you agree with the suggestion).
Something that is not clear to me: for value objects, why do we need 2 make() methods again?
BalduinLandolt
approved these changes
Jan 13, 2022
BalduinLandolt
left a comment
BalduinLandolt
left a comment
Contributor
There was a problem hiding this comment.
Looks good over all. I added some minor things. And I don't get the validation.success(None) part.
subotic
approved these changes
Jan 14, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DEV-240