Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): add ArchiveRepresentation to API V1 (DEV-393) (DEV-394) #1984

merged 8 commits into from Jan 31, 2022


Copy link

@BalduinLandolt BalduinLandolt commented Jan 18, 2022

resolves DEV-393
resolves DEV-394

@BalduinLandolt BalduinLandolt self-assigned this Jan 18, 2022
@BalduinLandolt BalduinLandolt changed the title feat(resource): add ArchiveRepresentation to API V1 (DEV-393) feat(resource): add ArchiveRepresentation to API V1 (DEV-393) (DEV-394) Jan 18, 2022
@BalduinLandolt BalduinLandolt marked this pull request as ready for review January 27, 2022 10:02
@BalduinLandolt BalduinLandolt requested review from mpro7 and irinaschubert and removed request for mdelez January 27, 2022 10:03
Comment on lines 263 to 266
// "application/zip",
// "application/x-tar",
// "application/x-iso9660-image",
// "application/gzip"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to remove what you've moved to archiveMimeTypes

@BalduinLandolt BalduinLandolt removed the request for review from irinaschubert January 27, 2022 15:50
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BalduinLandolt BalduinLandolt merged commit 65b88a2 into main Jan 31, 2022
@BalduinLandolt BalduinLandolt deleted the wip/DEV-393-create-archive-representation-in-v1 branch January 31, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants