Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology): Sub-properties of link values aren't created correctly (DEV-426) #1985

Merged
merged 17 commits into from Jan 27, 2022

Conversation

irinaschubert
Copy link
Collaborator

@irinaschubert irinaschubert commented Jan 25, 2022

resolves DEV-426

@irinaschubert irinaschubert self-assigned this Jan 25, 2022
commit 7dd0048
Author: irinaschubert <irina.schubert@dasch.swiss>
Date:   Wed Jan 26 08:43:50 2022 +0100

    make naming more consistent

commit 1ecaac1
Author: irinaschubert <irina.schubert@dasch.swiss>
Date:   Tue Jan 25 18:22:06 2022 +0100

    remove hasLinkTo and hasLinkToValue for subproperty
@irinaschubert irinaschubert marked this pull request as ready for review Jan 27, 2022
@irinaschubert irinaschubert requested a review from subotic as a code owner Jan 27, 2022
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Jan 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

mpro7
mpro7 approved these changes Jan 27, 2022
Copy link
Collaborator

@mpro7 mpro7 left a comment

Looks ok, but check if you can somehow improve TTL formatting.

test_data/ontologies/freetest-onto.ttl Show resolved Hide resolved
test_data/ontologies/freetest-onto.ttl Show resolved Hide resolved
test_data/ontologies/freetest-onto.ttl Show resolved Hide resolved
@irinaschubert irinaschubert merged commit 70a8b08 into main Jan 27, 2022
13 checks passed
@irinaschubert irinaschubert deleted the wip/dev-426-bug-subproperties-of-link-values branch Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants