Skip to content

fix(ontology): Sub-properties of link values aren't created correctly (DEV-426) - #1985

Merged
irinaschubert merged 17 commits into
mainfrom
wip/dev-426-bug-subproperties-of-link-values
Jan 27, 2022
Merged

fix(ontology): Sub-properties of link values aren't created correctly (DEV-426)#1985
irinaschubert merged 17 commits into
mainfrom
wip/dev-426-bug-subproperties-of-link-values

Conversation

@irinaschubert

@irinaschubert irinaschubert commented Jan 25, 2022

Copy link
Copy Markdown

resolves DEV-426

@irinaschubert irinaschubert self-assigned this Jan 25, 2022
irinaschubert added 4 commits January 26, 2022 08:44
irinaschubert
Squashed commit of the following:
7053130 
commit 7dd0048
Author: irinaschubert <irina.schubert@dasch.swiss>
Date:   Wed Jan 26 08:43:50 2022 +0100

    make naming more consistent

commit 1ecaac1
Author: irinaschubert <irina.schubert@dasch.swiss>
Date:   Tue Jan 25 18:22:06 2022 +0100

    remove hasLinkTo and hasLinkToValue for subproperty
irinaschubert
update test and testdata
d640945
irinaschubert
fix bug
b759afa
irinaschubert
Merge branch 'main' into wip/dev-426-bug-subproperties-of-link-values
5333e0d
@irinaschubert
irinaschubert marked this pull request as ready for review January 27, 2022 08:20
@sonarqubecloud

sonarqubecloud Bot commented Jan 27, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

mpro7
mpro7 approved these changes Jan 27, 2022
View reviewed changes

@mpro7 mpro7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but check if you can somehow improve TTL formatting.

Comment thread test_data/ontologies/freetest-onto.ttl
Comment thread test_data/ontologies/freetest-onto.ttl
Comment thread test_data/ontologies/freetest-onto.ttl
@irinaschubert
irinaschubert merged commit 70a8b08 into main Jan 27, 2022
@irinaschubert
irinaschubert deleted the wip/dev-426-bug-subproperties-of-link-values branch January 27, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subotic subotic subotic approved these changes
@mpro7 mpro7 mpro7 approved these changes
@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@irinaschubert irinaschubert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@irinaschubert @subotic @mpro7 @BalduinLandolt