Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade Jena to v4.3.2 (DEV-473) #1995

Merged
merged 3 commits into from Feb 7, 2022
Merged

chore(deps): upgrade Jena to v4.3.2 (DEV-473) #1995

merged 3 commits into from Feb 7, 2022

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Feb 4, 2022

resolves DEV-473

@mpro7 mpro7 self-assigned this Feb 4, 2022
@mpro7 mpro7 requested a review from subotic as a code owner Feb 4, 2022
@subotic
Copy link
Collaborator

@subotic subotic commented Feb 5, 2022

@mpro7 could you also please remove:

maven.artifact(
                group = "org.apache.jena",
                artifact = "jena-text",
                version = JENA_VERSION,
                exclusions = [
                    "org.slf4j:slf4j-log4j12",
                ],
            ),

and

"org.apache.logging.log4j:log4j:2.17.0", # needed by apache-jena-libs. explicitly setting latest version (log4shell) to override the one used by jena.

from dsp-api/third_party/dependencies.bzl?

Both are not needed anymore, now that the Jena library is updated and pulls in the correct log4j version.

subotic
subotic approved these changes Feb 5, 2022
@mpro7
Copy link
Collaborator Author

@mpro7 mpro7 commented Feb 7, 2022

@subotic are you sure about your request? I tried to do that and at least jena-text is still used:

webapi/src/main/scala/org/knora/webapi/store/triplestore/embedded/JenaTDBActor.scala:14: error: object text is not a member of package org.apache.jena.query
import org.apache.jena.query.text._

@subotic
Copy link
Collaborator

@subotic subotic commented Feb 7, 2022

@mpro7 yes, you are right. you would need to add jena-text in the same way the other jena libraries are added. What this bit of code does is to exclude the old verson of org.slf4j:slf4j-log4j12. Now we don't need to exclude it anymore but we still need to add the dependency to jena-text.

@mpro7
Copy link
Collaborator Author

@mpro7 mpro7 commented Feb 7, 2022

@subotic everything is clear now, thanks.

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mpro7 mpro7 merged commit 216dcb4 into main Feb 7, 2022
13 checks passed
@mpro7 mpro7 deleted the wip/DEV-473 branch Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants