build: BAZEL to SBT migration (DEV-508) #2002
Conversation
subotic
changed the title
mpro7
changed the title
webapi/src/test/scala/org/knora/webapi/e2e/http/ServerVersionE2ESpec.scala
Outdated
Show resolved
Hide resolved
| "v1/test", | ||
| "v2/test" |
There was a problem hiding this comment.
It is not necessary anymore. Inside the test that tests this functionality, the config contains these entries.
| @@ -112,7 +113,8 @@ class ITKnoraLiveSpec(_system: ActorSystem) | |||
|
|
|||
| override def afterAll(): Unit = | |||
| /* Stop the server when everything else has finished */ | |||
| appActor ! AppStop() | |||
| // appActor ! AppStop() | |||
There was a problem hiding this comment.
Do we still need this line of code?
webapi/src/test/scala/org/knora/webapi/e2e/ClientTestDataCollector.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/e2e/admin/lists/OldListsRouteADMFeatureE2ESpec.scala
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/e2e/http/ServerVersionE2ESpec.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/http/version/BuildInfoSpec.scala
Outdated
Show resolved
Hide resolved
| clientTestDataCollector.addFile( | ||
| TestDataFileContent( | ||
| filePath = TestDataFilePath( | ||
| directoryPath = clientTestDataPath, | ||
| filename = "create-int-value-with-custom-UUID-request", | ||
| fileExtension = "json" | ||
| ), | ||
| text = jsonLDEntity | ||
| ) | ||
| ) | ||
|
|
There was a problem hiding this comment.
why is this deleted?
There was a problem hiding this comment.
Interesting finding, I can't even spot it in the git blame who did it 😄
There was a problem hiding this comment.
because it was in the "do not create an integer value if the custom UUID is not part of the custom IRI" test. the "create an integer value with a custom UUID" was the previous test (same file name).
|
Kudos, SonarCloud Quality Gate passed!
|
resolves DEV-508