Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: BAZEL to SBT migration (DEV-508) #2002

Merged
merged 46 commits into from Feb 23, 2022
Merged

build: BAZEL to SBT migration (DEV-508) #2002

merged 46 commits into from Feb 23, 2022

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Feb 15, 2022

resolves DEV-508

@subotic subotic closed this Feb 15, 2022
@subotic subotic deleted the wip/DEV-508 branch Feb 15, 2022
@mpro7 mpro7 restored the wip/DEV-508 branch Feb 16, 2022
@mpro7 mpro7 reopened this Feb 16, 2022
@subotic subotic changed the title bring sbt configuration back chore: change back to SBT (DEV-508) Feb 17, 2022
@mpro7 mpro7 self-assigned this Feb 18, 2022
@mpro7 mpro7 changed the title chore: change back to SBT (DEV-508) build: BAZEL to SBT migration (DEV-508) Feb 21, 2022
@mpro7 mpro7 marked this pull request as ready for review Feb 21, 2022
@mpro7 mpro7 requested a review from subotic as a code owner Feb 21, 2022
project/Dependencies.scala Outdated Show resolved Hide resolved
Copy link
Collaborator

@irinaschubert irinaschubert left a comment

I don't feel like I have much to say but it looks interesting :) Added mostly minor deletion suggestions for uncommented code.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
project/plugins.sbt Show resolved Hide resolved
third_party/dependencies.bzl Show resolved Hide resolved
"v1/test",
"v2/test"
Copy link
Collaborator

@irinaschubert irinaschubert Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we use this anymore?

Copy link
Collaborator

@subotic subotic Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary anymore. Inside the test that tests this functionality, the config contains these entries.

@@ -112,7 +113,8 @@ class ITKnoraLiveSpec(_system: ActorSystem)

override def afterAll(): Unit =
/* Stop the server when everything else has finished */
appActor ! AppStop()
// appActor ! AppStop()
Copy link
Collaborator

@irinaschubert irinaschubert Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this line of code?

Copy link
Collaborator

@subotic subotic Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, removed

.gitignore Show resolved Hide resolved
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

certainly the license and URLs need to be adjusted in the build file. Apart from that just minor comments and questions.
(Also, sorry that I didn't bundle most comments with the review!)

Overall I like SBT much better than Bazel :)

clientTestDataCollector.addFile(
TestDataFileContent(
filePath = TestDataFilePath(
directoryPath = clientTestDataPath,
filename = "create-int-value-with-custom-UUID-request",
fileExtension = "json"
),
text = jsonLDEntity
)
)

Copy link
Collaborator

@BalduinLandolt BalduinLandolt Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this deleted?

Copy link
Collaborator Author

@mpro7 mpro7 Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting finding, I can't even spot it in the git blame who did it 😄

Copy link
Collaborator Author

@mpro7 mpro7 Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok found it - @subotic why did you delete it? 5d66fa9

Copy link
Collaborator

@subotic subotic Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it was in the "do not create an integer value if the custom UUID is not part of the custom IRI" test. the "create an integer value with a custom UUID" was the previous test (same file name).

build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
25.3% 25.3% Duplication

@mpro7 mpro7 merged commit 38faa9e into main Feb 23, 2022
11 checks passed
@mpro7 mpro7 deleted the wip/DEV-508 branch Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants