fix(permissions): Update default object access permissions (DEV-514) #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
subotic
approved these changes
Feb 17, 2022
mpro7
approved these changes
Feb 18, 2022
| PermissionADM.modifyPermission(OntologyConstants.KnoraAdmin.ProjectAdmin), | ||
| PermissionADM.viewPermission(OntologyConstants.KnoraAdmin.ProjectAdmin), | ||
| PermissionADM.restrictedViewPermission(OntologyConstants.KnoraAdmin.ProjectAdmin) | ||
| PermissionADM.modifyPermission(OntologyConstants.KnoraAdmin.ProjectMember) |
There was a problem hiding this comment.
Shouldn't the most privileged permission contain all the others? This line then wouldn't be necessary for too.
Comment on lines
+139
to
+150
| - `name` : indicates the type of the permission that can be one of the followings. | ||
| - `RV`: restricted view permission (least privileged) | ||
| - `V`: view permission | ||
| - `M` modify permission | ||
| - `D`: delete permission | ||
| - `CR`: change rights permission (most privileged) | ||
| - `permissionCode`: The code assigned to a permission indicating its hierarchical level. These codes are as below: | ||
| - `1`: for restricted view permission (least privileged) | ||
| - `2`: for view permission | ||
| - `6`: for modify permission | ||
| - `7`: for delete permission | ||
| - `8`: for change rights permission (most privileged) |
There was a problem hiding this comment.
Why do we need both ways to describe permissions?
There was a problem hiding this comment.
I have no idea why both are used, I stumbled upon it as well but it is not the scope of this PR.
There was a problem hiding this comment.
V1 and V2. V1 use numbers and V2 uses letters.
irinaschubert
deleted the
wip/DEV-514-adjust-default-object-access-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-514