Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology)!: make knora-base:lastModificationDate required property #2018

Merged
merged 25 commits into from Mar 30, 2022

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Mar 9, 2022

Resolves DEV-464

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mpro7 mpro7 self-assigned this Mar 9, 2022
@mpro7 mpro7 changed the title make lastModificationDate required feat!(ontologies): make knora-base:lastModificationDate required property Mar 18, 2022
@mpro7 mpro7 changed the title feat!(ontologies): make knora-base:lastModificationDate required property feat(ontologies)!: make knora-base:lastModificationDate required property Mar 23, 2022
@mpro7 mpro7 marked this pull request as ready for review Mar 23, 2022
@mpro7 mpro7 requested a review from subotic as a code owner Mar 23, 2022
Copy link
Collaborator

@irinaschubert irinaschubert left a comment

LGTM

One quetion though: why do SystemProjects not have a lastModificationDate?

@mpro7 mpro7 changed the title feat(ontologies)!: make knora-base:lastModificationDate required property feat(ontology)!: make knora-base:lastModificationDate required property Mar 30, 2022
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Mar 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mpro7 mpro7 merged commit 64cdce9 into main Mar 30, 2022
11 checks passed
@mpro7 mpro7 deleted the DEV-464-make-last-modification-date-as-a-required-property branch Mar 30, 2022
@daschbot daschbot mentioned this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants