refactor(cacheservice): use ZIO (DEV-546) #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-swiss/dsp-api into wip/DEV-546-zio-fying-cache-service
subotic
changed the title
mpro7
reviewed
Apr 8, 2022
| @@ -1,6 +1,6 @@ | |||
| version = "2.7.5" | |||
| maxColumn = 120 | |||
| align.preset = some | |||
| align.preset = most | |||
There was a problem hiding this comment.
now we going to have a lot of formatting noise
Comment on lines
411
to
418
| // get current user information | ||
| currentUserInformation: Option[UserADM] <- getSingleUserADM( | ||
| identifier = UserIdentifierADM(maybeIri = Some(userIri)), | ||
| userInformationType = UserInformationTypeADM.Full, | ||
| featureFactoryConfig = featureFactoryConfig, | ||
| requestingUser = KnoraSystemInstances.Users.SystemUser | ||
| ) | ||
| identifier = UserIdentifierADM(maybeIri = Some(userIri)), | ||
| userInformationType = UserInformationTypeADM.Full, | ||
| featureFactoryConfig = featureFactoryConfig, | ||
| requestingUser = KnoraSystemInstances.Users.SystemUser | ||
| ) | ||
|
|
There was a problem hiding this comment.
This also looks weird. Whole file is also just formatting...
irinaschubert
approved these changes
Apr 8, 2022
docs/architecture/decisions/0002-change-cache-service-manager-from-akka-actor-to-zlayer.md
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ProjectsResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/CacheServiceManager.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/config/CacheServiceConfig.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/impl/CacheServiceInMemImpl.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/impl/CacheServiceInMemImpl.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/store/cacheservice/impl/CacheServiceInMemImpl.scala
Show resolved
Hide resolved
| * | ||
| * @tparam T the type parameter of our value. | ||
| * @tparam A the type parameter of our value. |
There was a problem hiding this comment.
@param bytes should probably also be documented
There was a problem hiding this comment.
yes, will do that after I find a better implementation regarding serialisation.
…eServiceManager.scala Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…eServiceManager.scala Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…eServiceManager.scala Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…from-akka-actor-to-zlayer.md Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…h-swiss/dsp-api into wip/DEV-546-zio-fying-cache-service
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DEV-546
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: DSP-546
What is the new behavior?
Does this PR introduce a breaking change?
Other information