Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication)!: add server specific issuer to JWT token (DEV-555) #2024

merged 10 commits into from Mar 23, 2022


Copy link

@irinaschubert irinaschubert commented Mar 17, 2022

Resolves DEV-555

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this Mar 17, 2022
@irinaschubert irinaschubert changed the title fix(authentication): cookie stays valid when changing servers (DEV-555) fix(authentication): add server specific issuer to JWT token (DEV-555) Mar 22, 2022
@irinaschubert irinaschubert marked this pull request as ready for review March 22, 2022 07:42
@irinaschubert irinaschubert changed the title fix(authentication): add server specific issuer to JWT token (DEV-555) fix(authentication)!: add server specific issuer to JWT token (DEV-555) Mar 22, 2022
Copy link

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

sipi/scripts/jwt.lua Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit 4bd5b2f into main Mar 23, 2022
@irinaschubert irinaschubert deleted the wip/dev-555-authentication-problem branch March 23, 2022 09:07
@daschbot daschbot mentioned this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants