Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(version): fix displayed versions #2026

Merged
merged 3 commits into from Mar 24, 2022
Merged

fix(version): fix displayed versions #2026

merged 3 commits into from Mar 24, 2022

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Mar 24, 2022 •
edited

Resolves DEV-276

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mpro7 mpro7 requested a review from subotic as a code owner March 24, 2022 07:02
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

irinaschubert
irinaschubert approved these changes Mar 24, 2022
View reviewed changes
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

webapi/src/main/scala/org/knora/webapi/routing/VersionRoute.scala
"sipi" -> JsString(result.sipi),
"fuseki" -> JsString(result.fuseki)
).compactPrint
"name" -> JsString("version"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this line?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, but then it is a breaking change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. but instead of improvements to this route I just fixed it with small refactoring to avoid breaking changes...

@mpro7 mpro7 merged commit 566285c into main Mar 24, 2022
@mpro7 mpro7 deleted the DEV-276-dsp-api-doesnt-show-correct-version branch March 24, 2022 08:00
@mpro7 mpro7 self-assigned this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

@irinaschubert irinaschubert irinaschubert approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt

Assignees

@mpro7 mpro7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpro7 @subotic @irinaschubert