Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: distinguish between compile, runtime and test dependencies #2028

Merged

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Mar 28, 2022

Resolves DEV-604

Dependencies defined from line 101 were found by plugin as missing for compilation. Although I added these, they are commented out for now and compilation runs w/o any problems. @subotic please have a look if we really need them. I'll either remove them or uncomment in following task which is also related to dependencies.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mpro7 mpro7 self-assigned this Mar 28, 2022
@mpro7 mpro7 changed the title add missing dependencies build: distinguish between compile, runtime and test dependencies Mar 31, 2022
@mpro7 mpro7 marked this pull request as ready for review Mar 31, 2022
@mpro7 mpro7 requested a review from subotic as a code owner Mar 31, 2022
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mpro7 mpro7 merged commit 7cb326f into main Mar 31, 2022
11 checks passed
@mpro7 mpro7 deleted the DEV-604-distinguish-between-compile-time-runtime-and-test-libraries branch Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants