Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ontology): Add support for additional ontologies (DEV-512) #2029

Merged
merged 16 commits into from Apr 6, 2022

Conversation

irinaschubert
Copy link
Collaborator

@irinaschubert irinaschubert commented Mar 29, 2022

Resolves DEV-512

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this Mar 29, 2022
@irinaschubert irinaschubert marked this pull request as ready for review Apr 4, 2022
@irinaschubert irinaschubert requested a review from subotic as a code owner Apr 4, 2022
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

LGTM

mpro7
mpro7 approved these changes Apr 5, 2022
Copy link
Collaborator

@mpro7 mpro7 left a comment

You're missing type annotation in many lines, but apart of that it looks good.

subotic
subotic approved these changes Apr 6, 2022
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.8% 9.8% Duplication

@irinaschubert irinaschubert merged commit 50e3186 into main Apr 6, 2022
11 checks passed
@irinaschubert irinaschubert deleted the wip/DEV-512-add-support-for-additional-ontologies branch Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants