New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace Bazel and Intellij documentation with SBT and VSCode (DEV-607) #2035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor stuff
@@ -0,0 +1,37 @@ | |||
# Setup Visual Studio Code for development of DSP-API | |||
|
|||
To have full functionality, the "Scala (Metals)" plugin should be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have full functionality, the "Scala (Metals)" plugin should be installed. | |
To have full functionality, the [Scala Metals](https://scalameta.org/metals/) plugin should be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally didn't add too many links all over the place. Do you think I should? (So far, this seems to be pretty common in the docs, but I feel a bit silly for example to add a link to each instance of "VSCode" in the text...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look to my suggestions.
Kudos, SonarCloud Quality Gate passed!
|
Resolves DEV-607
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information