Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): Add accepted file formats to documentation (DEV-677) #2038

Merged
merged 8 commits into from Apr 12, 2022
Merged

docs(ingest): Add accepted file formats to documentation (DEV-677) #2038

merged 8 commits into from Apr 12, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Apr 8, 2022 •
edited

Resolves DEV-677

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this Apr 8, 2022
@irinaschubert irinaschubert marked this pull request as ready for review April 8, 2022 15:54
subotic
subotic approved these changes Apr 8, 2022
View reviewed changes
docs/01-introduction/data-formats.md Outdated Show resolved Hide resolved
docs/01-introduction/data-formats.md Outdated Show resolved Hide resolved
BalduinLandolt
BalduinLandolt requested changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the case of Text -> Standoff conversion on ingest needs to be covered in this part of the docs.

docs/01-introduction/data-formats.md Outdated Show resolved Hide resolved
irinaschubert
irinaschubert commented Apr 12, 2022
View reviewed changes
docs/01-introduction/data-formats.md Outdated Show resolved Hide resolved
docs/01-introduction/file-formats.md Outdated Show resolved Hide resolved
BalduinLandolt
BalduinLandolt approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpro7
mpro7 reviewed Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one tiny thing you forgot ;)

docs/faq/index.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irinaschubert irinaschubert merged commit f72e7a0 into main Apr 12, 2022
@irinaschubert irinaschubert deleted the wip/DEV-677-add-file-formats-to-docs branch April 12, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 left review comments

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@subotic subotic subotic approved these changes

Assignees

@irinaschubert irinaschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@irinaschubert @subotic @mpro7 @BalduinLandolt