Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sipi): extract frames from video even without aspect ratio (DEV-802) #2041

merged 2 commits into from Apr 13, 2022


Copy link

@kilchenmann kilchenmann commented Apr 12, 2022

Resolves DEV-802

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kilchenmann kilchenmann added the bug label Apr 12, 2022
@kilchenmann kilchenmann self-assigned this Apr 12, 2022
@kilchenmann kilchenmann requested a review from mdelez Apr 12, 2022
mdelez approved these changes Apr 13, 2022
Copy link

@mdelez mdelez left a comment

Thanks! Let's hope this can catch all the edge cases :)

@kilchenmann kilchenmann requested a review from irinaschubert Apr 13, 2022
Copy link

@sonarcloud sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kilchenmann kilchenmann merged commit 57d40f7 into main Apr 13, 2022
11 checks passed
@kilchenmann kilchenmann deleted the wip/dev-802-fix-sipi-video-script branch Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

2 participants