Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(IIIFService): zio-fying iiif service (DEV-801) #2044

Merged
merged 50 commits into from May 5, 2022

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Apr 13, 2022

Resolves DEV-801

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@subotic subotic self-assigned this Apr 13, 2022
Copy link
Collaborator

@irinaschubert irinaschubert left a comment

LGTM although I can't really contribute anything regarding ZIO, just added some minor stuff (typos, questions).

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Mostly looks good and seems a big improvement, thanks!

I added some smaller remarks that you may want to consider.

Finally, I'm not sure why ValuesResponderV2Spec.scala does what it should. (See my comment there.) Please have a look at that.

subotic and others added 11 commits May 3, 2022
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…Container.scala

Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…Service.scala

Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…Service.scala

Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…Service.scala

Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…Service.scala

Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
…-swiss/knora-api into wip/DEV-801-zio-fying-iiif-service
Copy link
Collaborator

@mpro7 mpro7 left a comment

Not everything is clear for me in this PR but found some issues related to code readability.

@BalduinLandolt BalduinLandolt self-requested a review May 5, 2022
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
9.9% 9.9% Duplication

@subotic subotic merged commit 224b664 into main May 5, 2022
12 checks passed
@subotic subotic deleted the wip/DEV-801-zio-fying-iiif-service branch May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants