Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gravsearch): improve gravsearch performance by using unions in prequery (DEV-492) #2045

Merged
merged 36 commits into from May 10, 2022

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Apr 16, 2022

Resolves DEV-492

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other: Performance improvements.

What is the current behavior?

Issue Number: DEV-492

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@BalduinLandolt BalduinLandolt self-assigned this Apr 16, 2022
@BalduinLandolt
Copy link
Collaborator Author

@BalduinLandolt BalduinLandolt commented Apr 21, 2022

Open Questions at this point:

  • How should execution context actually be handled
  • What is a sensible duration for a Gravsearch query? (I randomly picked 3s) When a query takes longer than this, a warning will be logged

@BalduinLandolt BalduinLandolt marked this pull request as ready for review Apr 21, 2022
@BalduinLandolt BalduinLandolt requested review from mpro7 and subotic May 5, 2022
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
Copy link
Collaborator

@mpro7 mpro7 left a comment

Great job! Have a look few comments I left.

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@BalduinLandolt BalduinLandolt merged commit 40354a7 into main May 10, 2022
12 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/DEV-492-gravsearch-performance-attempt-2 branch May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants