New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gravsearch): improve gravsearch performance by using unions in prequery (DEV-492) #2045
feat(gravsearch): improve gravsearch performance by using unions in prequery (DEV-492) #2045
Conversation
Open Questions at this point:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor things
webapi/src/main/scala/org/knora/webapi/messages/util/search/SparqlTransformer.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/messages/util/search/SparqlTransformer.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/messages/util/search/SparqlTransformer.scala
Outdated
Show resolved
Hide resolved
...la/org/knora/webapi/messages/util/search/gravsearch/prequery/AbstractPrequeryGenerator.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/v2/SearchResponderV2.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/v2/SearchResponderV2.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Have a look few comments I left.
webapi/src/main/scala/org/knora/webapi/messages/util/search/QueryTraverser.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/v2/SearchResponderV2.scala
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
Resolves DEV-492
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: DEV-492
What is the new behavior?
Does this PR introduce a breaking change?
Other information