Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(formatting-logging): reformat scala code and change logging policy (DEV-839) #2051

merged 4 commits into from Apr 26, 2022


Copy link

Resolves DEV-839

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-839

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@BalduinLandolt BalduinLandolt self-assigned this Apr 26, 2022
@BalduinLandolt BalduinLandolt marked this pull request as ready for review April 26, 2022 15:03
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
11.4% 11.4% Duplication

@irinaschubert irinaschubert merged commit 5e4e914 into main Apr 26, 2022
@irinaschubert irinaschubert deleted the wip/DEV-839-code-maintainance branch April 26, 2022 15:50
Copy link

subotic commented Apr 26, 2022

@BalduinLandolt how was the reformatting done?

Copy link
Collaborator Author

@BalduinLandolt how was the reformatting done?

@subotic I used the SBT plugin but didn't enable it permanently. See here:

// addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.6")

And then I used the command to format all files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants