New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: check that the expected Fuseki version is present (DEV-331) #2057
chore: check that the expected Fuseki version is present (DEV-331) #2057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In terms of code style: I think such long comments should not be on the same line as the code, but on the line before. But that's cosmetics
OK, I understand. I thought if it is on the same line, it is more obvious that it should be read. If it is above, one could easily not see it and forget to udpate the versions in the other places. What is your opinion on that? |
Also makes sense. And if it has a functional purpose, I'm happy to live with a bit of ugly long lines :) |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather place comments in new line instead of making lines so long.
I leave it on the same line. I'm afraid that we could forget to update the version in ops-deploy if we put the comment above or below. Hope that's OK for you, @mpro7 . We can still change it in the future should it bother us too much. |
IMO it works the other way around. Longer lines are usually less readable and easy to omit the info. That's just general remark and one of good practices to break the lines if too long, but yeah... whatever ;) |
Resolves DEV-331
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: DEV-331
What is the new behavior?
Does this PR introduce a breaking change?
Other information