feat(admin): add list child node deletion route (DEV-729) #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpro7
changed the title
BalduinLandolt
requested changes
May 16, 2022
...rc/main/scala/org/knora/webapi/messages/admin/responder/listsmessages/ListsMessagesADM.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/knora/webapi/messages/admin/responder/listsmessages/ListsMessagesADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
...l/org/knora/webapi/messages/twirl/queries/sparql/admin/deleteListChildNodeComments.scala.txt
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
irinaschubert
suggested changes
May 16, 2022
There was a problem hiding this comment.
I'm not sure if everywhere we need to have the "child" in the names of the methods, classes and values. I think "node" itself would be enough. You stated in the docstrings and documentation that it is not possible to delete comments of a root node. In my opinion this should be enough.
...rc/main/scala/org/knora/webapi/messages/admin/responder/listsmessages/ListsMessagesADM.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/org/knora/webapi/messages/admin/responder/listsmessages/ListsMessagesADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/admin/lists/DeleteListItemsRouteADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/e2e/admin/lists/OldListsRouteADMFeatureE2ESpec.scala
Show resolved
Hide resolved
webapi/src/test/scala/org/knora/webapi/responders/admin/ListsResponderADMSpec.scala
Show resolved
Hide resolved
|
@irinaschubert I have also mixed feelings about the "child" in all names, but I was already working a lot with lists and I know what messy naming is there. However I removed it and left only in info in docstrings. Now let's wait until first complaint of why it's missing :D |
irinaschubert
approved these changes
May 24, 2022
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/admin/lists/DeleteListItemsRouteADM.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/routing/admin/lists/DeleteListItemsRouteADM.scala
Outdated
Show resolved
Hide resolved
BalduinLandolt
approved these changes
May 24, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
mpro7
deleted the
DEV-729-add-separate-route-for-deleting-list-node-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: DEV-729
What is the new behavior?
Does this PR introduce a breaking change?
Other information