New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cache): cache does not update correctly when an ontology is modified (DEV-939) #2068
fix(cache): cache does not update correctly when an ontology is modified (DEV-939) #2068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
The naming of methods and variables is not always clear to me, but we can improve that when we refactor it.
…/github.com/dasch-swiss/dsp-api into wip/DEV-939-update-cache-on-ontology-change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Hope that all test will pass :)
webapi/src/main/scala/org/knora/webapi/responders/v2/ontology/Cache.scala
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
Resolves DEV-939
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After adding a class to an ontology, instances of this class cannot be found with gravsearch because the cache does not update correctly when modifying an ontology.
Issue Number: DEV-939
What is the new behavior?
The cache updates correctly
Does this PR introduce a breaking change?
Other information