refactor(v3): finish user slice (DEV-671) #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2022 11:10
added 14 commits
June 15, 2022 12:04
subotic
reviewed
Jun 17, 2022
dsp-user/core/src/test/scala/dsp/user/sharedtestdata/SharedTestData.scala
Outdated
Show resolved
Hide resolved
irinaschubert
changed the title
BalduinLandolt
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Over all, looks good, thanks!
Some things I commented on:
- various cosmetic/code style things... feel free to ignore
- I think in the UserDomainSpec you can simplify the tests by not wrapping everything into a for-comprehension and into ZIOs. Those tests should not need this.
- Typo in PR title scope. Please fix :)
dsp-user/handler/src/main/scala/dsp/user/handler/UserHandler.scala
Outdated
Show resolved
Hide resolved
dsp-user/handler/src/test/scala/dsp/user/handler/UserHandlerSpec.scala
Outdated
Show resolved
Hide resolved
dsp-user/repo/src/test/scala/dsp/user/repo/impl/UserRepoImplSpec.scala
Outdated
Show resolved
Hide resolved
|
darn... you already fixed thy typo in the PR title... ignore that bullet point then! ^^ |
mpro7
approved these changes
Jun 21, 2022
dsp-user/core/src/test/scala/dsp/user/domain/UserDomainSpec.scala
Outdated
Show resolved
Hide resolved
dsp-user/handler/src/main/scala/dsp/user/handler/UserHandler.scala
Outdated
Show resolved
Hide resolved
added 19 commits
June 28, 2022 16:18
subotic
reviewed
Jun 30, 2022
dsp-user/core/src/test/scala/dsp/user/domain/UserDomainSpec.scala
Outdated
Show resolved
Hide resolved
subotic
reviewed
Jun 30, 2022
dsp-user/core/src/test/scala/dsp/user/sharedtestdata/SharedTestData.scala
Show resolved
Hide resolved
subotic
approved these changes
Jun 30, 2022
mpro7
approved these changes
Jul 4, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DEV-671
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information