Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology): link value property is not editable after updating the property metadata (DEV-1037) #2084


Copy link

@BalduinLandolt BalduinLandolt commented Jun 23, 2022

Resolves DEV-1037

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

After editing property metadata (label or comment) of a link property, the property does not show up in the create resource form anymore.
This is because on the linkValueProperty (not the linkProperty itself) the API suddenly doesn't add isEditable: true anymore.

Issue Number: DEV-1037

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@BalduinLandolt BalduinLandolt marked this pull request as ready for review June 23, 2022 19:00
@BalduinLandolt BalduinLandolt self-assigned this Jun 23, 2022
Copy link

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to complain from my side :)

Copy link

sonarcloud bot commented Jun 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.2% 1.2% Duplication

@BalduinLandolt BalduinLandolt merged commit 09688f5 into main Jun 27, 2022
@BalduinLandolt BalduinLandolt deleted the wip/DEV-1037-link-value-property-not-editable-after-updating-property-metadata branch June 27, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants