Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ontology): existing cardinalities get duplicated in the triplestore when adding a new cardinality to a class (DEV-937) #2092


Copy link

Resolves DEV-937

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When adding a new cardinality to a resource class, all existing cardinalities of that class get duplicated in the triplestore. (Only visible in the triplestore, not in the API.)

Issue Number: DEV-937

What is the new behavior?

Cardinalities don't get duplicated.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@BalduinLandolt BalduinLandolt self-assigned this Jul 7, 2022
@BalduinLandolt BalduinLandolt marked this pull request as ready for review July 7, 2022 16:30
@BalduinLandolt BalduinLandolt requested review from irinaschubert, mpro7 and subotic and removed request for subotic, irinaschubert and mpro7 July 7, 2022 16:30
@BalduinLandolt BalduinLandolt marked this pull request as draft July 7, 2022 16:33
@BalduinLandolt BalduinLandolt marked this pull request as ready for review July 7, 2022 19:41
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

sonarcloud bot commented Jul 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BalduinLandolt BalduinLandolt merged commit 9fa26db into main Jul 11, 2022
11 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/DEV-937-cardinalities-get-duplicated-when-adding-a-cardinality-to-a-class branch July 11, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants