Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cardinality): Check cardinality with multiple inherited classes (DEV-1189) #2164

Merged
merged 25 commits into from Aug 23, 2022
Merged

fix(cardinality): Check cardinality with multiple inherited classes (DEV-1189) #2164

merged 25 commits into from Aug 23, 2022

Conversation

irinaschubert
Copy link

@irinaschubert irinaschubert commented Aug 15, 2022 •
edited

Resolves DEV-1189, DEV-1206

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@irinaschubert irinaschubert self-assigned this Aug 15, 2022
@irinaschubert irinaschubert marked this pull request as ready for review August 19, 2022 06:18
subotic
subotic approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

dsp-schema/core/src/main/scala/dsp/schema/domain/SchemaDomain.scala Outdated Show resolved Hide resolved
webapi/src/test/scala/org/knora/webapi/responders/v2/ontology/OntologyHelpersSpec.scala Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
28.3% 28.3% Duplication

BalduinLandolt
BalduinLandolt approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

docs/02-knora-ontologies/knora-base.md Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
.../webapi/messages/v2/responder/ontologymessages/KnoraCardinalityInfoIsStricterThanZSpec.scala Outdated Show resolved Hide resolved
@irinaschubert irinaschubert merged commit f183d7d into main Aug 23, 2022
9 checks passed
@irinaschubert irinaschubert deleted the wip/dev-1189-bug-with-inherited-cardinalities branch August 23, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@mpro7 mpro7 Awaiting requested review from mpro7

Assignees

@irinaschubert irinaschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irinaschubert @subotic @BalduinLandolt