Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: application actor (DEV-956) #2166

merged 47 commits into from Sep 9, 2022


Copy link

@subotic subotic commented Aug 18, 2022

Resolves DEV-956, DEV-300

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: DEV-956

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dasch-swiss dasch-swiss deleted a comment from sonarcloud bot Aug 20, 2022
@subotic subotic self-assigned this Aug 26, 2022
@subotic subotic marked this pull request as draft August 26, 2022 05:43
webapi/src/main/scala/org/knora/webapi/Experiments.scala Outdated Show resolved Hide resolved
webapi/src/main/scala/org/knora/webapi/Main.scala Outdated Show resolved Hide resolved
def putUserADM(value: UserADM): Task[Unit] =
for {
res <- cs.putUserADM(value) @@ cacheServiceWriteUserTimer.trackDuration
// _ <- cacheServiceWriteUserTimer.value.tap(value => ZIO.debug(value))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the usage of this timer? Is it to measure the time it takes to write something into the cache? What is the use case behind that?

webapi/src/test/scala/org/knora/webapi/CoreSpec.scala Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2166 (0e8cd7e) into main (71c772f) will increase coverage by 0.20%.
The diff coverage is 73.04%.

@@            Coverage Diff             @@
##             main    #2166      +/-   ##
+ Coverage   86.64%   86.84%   +0.20%     
  Files         233      243      +10     
  Lines       28020    28191     +171     
+ Hits        24277    24482     +205     
+ Misses       3743     3709      -34     
Impacted Files Coverage Δ
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 84.05% <0.00%> (-1.45%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...tore/triplestoremessages/TriplestoreMessages.scala 74.78% <ø> (-0.22%) ⬇️
...a/org/knora/webapi/messages/util/ValueUtilV1.scala 91.26% <ø> (-0.05%) ⬇️
...api/responders/admin/PermissionsResponderADM.scala 90.22% <ø> (ø)
...n/scala/org/knora/webapi/routing/RouteUtilV1.scala 81.81% <ø> (ø) 76.92% <ø> (ø)
.../scala/org/knora/webapi/routing/VersionRoute.scala 100.00% <ø> (ø) 85.71% <ø> (ø)
...rg/knora/webapi/routing/admin/GroupsRouteADM.scala 97.89% <ø> (ø)
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@subotic subotic marked this pull request as ready for review September 9, 2022 12:00
@subotic subotic merged commit 4852425 into main Sep 9, 2022
@subotic subotic deleted the wip/DEV-956-zio-fying-application-actor branch September 9, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants