Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust GitHub template (DEV-1313) #2183

merged 5 commits into from Aug 31, 2022


Copy link

@irinaschubert irinaschubert commented Aug 31, 2022

Resolves DEV-1313

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: updated this template

What is the current behavior?

Issue Number: DEV-1313

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

swarmia bot commented Aug 31, 2022

✅  Linked to Story DEV-1313 · DSP-API: Adjust GitHub PR template

@irinaschubert irinaschubert self-assigned this Aug 31, 2022
@irinaschubert irinaschubert marked this pull request as ready for review August 31, 2022 11:50
Copy link

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


.github/actions/preparation/action.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #2183 (78f51a8) into main (309f424) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2183      +/-   ##
- Coverage   86.64%   86.64%   -0.01%     
  Files         233      233              
  Lines       28020    28020              
- Hits        24278    24277       -1     
- Misses       3742     3743       +1     
Impacted Files Coverage Δ
...ore/impl/TriplestoreServiceHttpConnectorImpl.scala 80.85% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@irinaschubert irinaschubert merged commit 5782494 into main Aug 31, 2022
9 of 11 checks passed
@irinaschubert irinaschubert deleted the wip/dev-1313-adjust-github-template branch August 31, 2022 15:13
Copy link

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but check my thoughts about the PR template. I couldn't unfortunately make ready to commit suggestion on GH, but if you like I can push it to the branch from IDE.

.github/ Show resolved Hide resolved
.github/ Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants