Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip tests with Success (DEV-1112) #2188

merged 27 commits into from Sep 6, 2022


Copy link

@irinaschubert irinaschubert commented Sep 2, 2022

Issue Number: DEV-1112

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@irinaschubert irinaschubert self-assigned this Sep 2, 2022
Copy link

swarmia bot commented Sep 2, 2022

✅  Linked to Story DEV-1112 · DSP-API: Improve release speed

@irinaschubert irinaschubert marked this pull request as ready for review September 2, 2022 15:01
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #2188 (bb1ac5d) into main (71c772f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2188      +/-   ##
- Coverage   86.64%   86.64%   -0.01%     
  Files         233      233              
  Lines       28020    28019       -1     
- Hits        24277    24276       -1     
  Misses       3743     3743              
Impacted Files Coverage Δ
...a/org/knora/webapi/messages/util/ValueUtilV1.scala 91.26% <ø> (-0.05%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV1.scala 81.81% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@irinaschubert irinaschubert merged commit 82703d7 into main Sep 6, 2022
7 of 8 checks passed
@irinaschubert irinaschubert deleted the wip/dev-1112-skip-test-with-success branch September 6, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants