Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sipi): remove support for audio/mp4 file format (DEV-1300) #2195

merged 1 commit into from Sep 5, 2022


Copy link

@mpro7 mpro7 commented Sep 5, 2022

Issue Number: DEV-1300

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

Copy link

swarmia bot commented Sep 5, 2022

✅  Linked to Story DEV-1300 · DSP-API: Remove support for mp4 audio files

@mpro7 mpro7 self-assigned this Sep 5, 2022
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #2195 (cbad8d5) into main (71c772f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2195   +/-   ##
  Coverage   86.64%   86.64%           
  Files         233      233           
  Lines       28020    28019    -1     
  Hits        24277    24277           
+ Misses       3743     3742    -1     
Impacted Files Coverage Δ
...a/org/knora/webapi/messages/util/ValueUtilV1.scala 91.26% <ø> (-0.05%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV1.scala 81.81% <ø> (ø)
...ore/impl/TriplestoreServiceHttpConnectorImpl.scala 81.15% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mpro7 mpro7 requested review from irinaschubert, BalduinLandolt, jnussbaum and subotic and removed request for jnussbaum September 5, 2022 07:50
Copy link

@mpro7 : Before you merge, we should perhaps fix something else: If I try to upload a DOCX file with dsp-tools, I get the following error:

Uploaded file ./Documents/RosettaTestproject.docx
ERROR while trying to create resource 'RosettaDOCX' (doc_002). Error message: KNORA-ERROR: status code=400
Message:{"knora-api:error":"dsp.errors.BadRequestException: File 9GOHhvFt4uN-Bs61Gi88Jij.docx has MIME type application/vnd.openxmlformats-officedocument.wordprocessingml.document, which is not supported for text files","@context":{"knora-api":""}}

Apparently, the MIME type is not recognized correctly.

Why does it think that docx would be a "text file"? is that defined in the upload XML, in DSP-Tools, in SIPI or in DSP-API? Word files should be in the document category not in the text category, as far as I understand.

@mpro7 mpro7 closed this Sep 5, 2022
@mpro7 mpro7 reopened this Sep 5, 2022
Copy link

@BalduinLandolt: You're right. I made it wrong in my XML file. Sorry for having you disturbed :-)

Copy link

@jnussbaum no worries! I'd rather have it that way, than needing to fix stuff in the API (or even worse, in SIPI)... :-)

@mpro7 mpro7 removed the request for review from irinaschubert September 5, 2022 08:58
@mpro7 mpro7 changed the title fix(sipi): remove support for audio/mp4 file format fix(sipi): remove support for audio/mp4 file format (DEV-1300) Sep 5, 2022
@mpro7 mpro7 merged commit 122bf52 into main Sep 5, 2022
9 checks passed
@mpro7 mpro7 deleted the DEV-1300-dsp-api-remove-support-for-mp-4-audio-files branch September 5, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants