Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Timeout for multiple Gravsearch queries (DEV-1379) #2234

merged 2 commits into from Oct 5, 2022


Copy link

@irinaschubert irinaschubert commented Oct 4, 2022

Issue Number: DEV-1379

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@irinaschubert irinaschubert self-assigned this Oct 4, 2022
Copy link

swarmia bot commented Oct 4, 2022

✅  Linked to Bug DEV-1379 · DSP-API: one second time-out

@irinaschubert irinaschubert marked this pull request as ready for review October 4, 2022 12:52
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 86.64% // Head: 86.85% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (786cbe7) compared to base (71c772f).
Patch coverage: 84.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2234      +/-   ##
+ Coverage   86.64%   86.85%   +0.21%     
  Files         233      241       +8     
  Lines       28020    27965      -55     
+ Hits        24277    24290      +13     
+ Misses       3743     3675      -68     
Impacted Files Coverage Δ
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 84.05% <0.00%> (-1.45%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...n/responder/groupsmessages/GroupsMessagesADM.scala 73.33% <ø> (ø)
...sponder/projectsmessages/ProjectsMessagesADM.scala 91.19% <ø> (ø)
...tore/triplestoremessages/TriplestoreMessages.scala 74.78% <ø> (-0.22%) ⬇️
...webapi/messages/util/ConstructResponseUtilV2.scala 93.29% <ø> (ø)
...a/org/knora/webapi/messages/util/MessageUtil.scala 36.66% <ø> (ø)
...knora/webapi/messages/util/PermissionUtilADM.scala 84.54% <ø> (ø)
...vsearch/types/GravsearchTypeInspectionRunner.scala 100.00% <ø> (ø)
.../webapi/messages/v2/responder/KnoraRequestV2.scala 0.00% <ø> (ø)
... and 143 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats! Do we know, how long getting the project information takes? Do we still need to add caching of the projects at startup?

@irinaschubert irinaschubert merged commit c63567b into main Oct 5, 2022
@irinaschubert irinaschubert deleted the wip/dev-1379-timeout-with-multiple-queries branch October 5, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants