Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DSP-API project IRI validation fails for BEOL project IRI #2240



Copy link

@mpro7 mpro7 commented Oct 7, 2022

Issue Number: DEV-1389

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Other information

@mpro7 mpro7 requested a review from subotic October 7, 2022 08:33
@mpro7 mpro7 self-assigned this Oct 7, 2022
Copy link

swarmia bot commented Oct 7, 2022

Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 86.85% // Head: 86.86% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0fd6de9) compared to base (c5c98ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2240   +/-   ##
  Coverage   86.85%   86.86%           
  Files         241      241           
  Lines       27967    27969    +2     
+ Hits        24292    24294    +2     
  Misses       3675     3675           
Impacted Files Coverage Δ
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 84.50% <100.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mpro7 mpro7 merged commit 4b63a72 into main Oct 7, 2022
@mpro7 mpro7 deleted the DEV-1389-dsp-api-project-iri-validation-fails-for-beol-project-iri branch October 7, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants