Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt-header plugin to webapi project and add missing headers #2317

merged 2 commits into from Dec 5, 2022


Copy link

@seakayone seakayone commented Dec 2, 2022

Add plugin and missing Apache 2.0 headers to webapi project.

Headers can be added using sbt webapi/headerCreate and checked using sbt webapi/headerCheck

I have not found out how to do a proper setup with the multiproject setup we have. But this is already an improvement.

Pull Request Checklist

Task Description/Number

Add sbt plugin for adding missing apache-2.0 copyright headers

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone self-assigned this Dec 2, 2022
Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks.

@seakayone seakayone force-pushed the chore/add-copyright-header-sbt-plugin branch from f5637f2 to 3854f28 Compare December 2, 2022 15:04
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 86.95% // Head: 5.23% // Decreases project coverage by -81.71% ⚠️

Coverage data is based on head (6c4da1b) compared to base (bfe578a).
Patch coverage: 57.69% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2317       +/-   ##
- Coverage   86.95%   5.23%   -81.72%     
  Files         242     251        +9     
  Lines       28102   28266      +164     
- Hits        24435    1481    -22954     
- Misses       3667   26785    +23118     
Impacted Files Coverage Δ
...ain/scala/dsp/project/handler/ProjectHandler.scala 100.00% <ø> (ø)
.../src/main/scala/dsp/role/handler/RoleHandler.scala 88.00% <ø> (ø)
...c/main/scala/dsp/role/repo/impl/RoleRepoLive.scala 100.00% <ø> (ø)
...shared/src/main/scala/dsp/util/UuidGenerator.scala 0.00% <0.00%> (ø)
...erface/src/main/scala/dsp/user/route/GetUser.scala 0.00% <0.00%> (ø)
...ce/src/main/scala/dsp/user/route/MigrateUser.scala 0.00% <0.00%> (ø)
...ace/src/main/scala/dsp/user/route/UserRoutes.scala 0.00% <0.00%> (ø)
...c/main/scala/dsp/user/repo/impl/UserRepoLive.scala 100.00% <ø> (ø)
...sp-shared/src/main/scala/dsp/valueobjects/Id.scala 69.23% <66.66%> (+3.84%) ⬆️
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 91.75% <66.66%> (-2.93%) ⬇️
... and 220 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@seakayone seakayone merged commit afec4a7 into main Dec 5, 2022
9 checks passed
@seakayone seakayone deleted the chore/add-copyright-header-sbt-plugin branch December 5, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants