Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update admin documentation #2328

merged 3 commits into from Dec 7, 2022


Copy link

@BalduinLandolt BalduinLandolt commented Dec 7, 2022

Pull Request Checklist

Task Description/Number

Add missing documentation to admin endpoints docs.

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Copy link

@irinaschubert irinaschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, IMO you could as well remove the GET /admin/stores route if it is not used nor even implemented

Copy link
Collaborator Author

LGTM, IMO you could as well remove the GET /admin/stores route if it is not used nor even implemented

thanks for the review!
You're right. But in the spirit of small PRs (and descriptive PR titles) I'll do it in a separate task.

@BalduinLandolt BalduinLandolt merged commit cedb603 into main Dec 7, 2022
8 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/update-admin-documentation branch December 7, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants