Skip to content

fix!: return external representation of ontology IRIs in admin routes (DEV-974) - #2330

Merged
irinaschubert merged 58 commits into
mainfrom
wip/DEV-974-return-external-iris-in-admin-routes
Jan 3, 2023
Merged

irinaschubert merged 58 commits into
mainfrom
wip/DEV-974-return-external-iris-in-admin-routes

Conversation

@BalduinLandolt

@BalduinLandolt BalduinLandolt commented Dec 7, 2022 •

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-974

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@swarmia

swarmia Bot commented Dec 7, 2022

Copy link
Copy Markdown

@BalduinLandolt BalduinLandolt self-assigned this Dec 7, 2022
@BalduinLandolt

BalduinLandolt commented Dec 7, 2022 •

Copy link
Copy Markdown
Contributor Author

PR Progress / TODO

  • projects endpoint
  • user endpoint
  • groups endpoint
  • list endpoint
  • permissions endpoint

@codecov

codecov Bot commented Dec 7, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 86.68% // Head: 86.48% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (ad74065) compared to base (26e9596).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   86.68%   86.48%   -0.20%     
==========================================
  Files         250      271      +21     
  Lines       28252    28302      +50     
==========================================
- Hits        24490    24478      -12     
- Misses       3762     3824      +62     
Impacted Files Coverage Δ
...p-shared/src/main/scala/dsp/valueobjects/Iri.scala 93.93% <100.00%> (+0.12%) ⬆️
...sp-shared/src/main/scala/dsp/valueobjects/V2.scala 90.27% <100.00%> (+0.27%) ⬆️
.../scala/org/knora/webapi/responders/Responder.scala 75.00% <0.00%> (-16.43%) ⬇️
...org/knora/webapi/routing/v2/ResourcesRouteV2.scala 88.27% <0.00%> (-5.79%) ⬇️
.../webapi/messages/util/rdf/jenaimpl/JenaModel.scala 86.42% <0.00%> (-2.86%) ⬇️
...n/scala/org/knora/webapi/routing/RouteUtilV2.scala 64.93% <0.00%> (-1.74%) ⬇️
...la/org/knora/webapi/messages/StringFormatter.scala 88.72% <0.00%> (-0.80%) ⬇️
...knora/webapi/responders/v1/ValuesResponderV1.scala 92.73% <0.00%> (-0.01%) ⬇️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 93.43% <0.00%> (-0.01%) ⬇️
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BalduinLandolt BalduinLandolt changed the title comment out potentially unused message and receive method for it refactor(admin): return external representation of IRIs in admin routes Dec 7, 2022
@irinaschubert irinaschubert self-assigned this Dec 14, 2022
@irinaschubert irinaschubert changed the title refactor!: return external representation of ontology IRIs in admin routes fix!: return external representation of ontology IRIs in admin routes Dec 22, 2022

@BalduinLandolt BalduinLandolt left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to approve, but GutHub doesn't let me because it considers me an author of the PR

Comment thread docs/03-endpoints/api-admin/projects.md Outdated
irinaschubert and others added 5 commits January 3, 2023 10:02
@seakayone

Copy link
Copy Markdown
Contributor

LGTM, just some minor coding style comments. Feel free to ignore them.

@mpro7 mpro7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, removed a lot of dead code :)

irinaschubert and others added 2 commits January 3, 2023 11:08
@irinaschubert
irinaschubert merged commit b58828a into main Jan 3, 2023
@irinaschubert
irinaschubert deleted the wip/DEV-974-return-external-iris-in-admin-routes branch January 3, 2023 14:57
@daschbot daschbot mentioned this pull request Jan 3, 2023
@irinaschubert irinaschubert changed the title fix!: return external representation of ontology IRIs in admin routes fix!: return external representation of ontology IRIs in admin routes (DEV-974) Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants