Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify health route setup #2337

merged 2 commits into from Dec 12, 2022


Copy link

Refactoring: Turn Health Route into object and remove redundant indirection

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix: represents bug fixes
  • Refactor: represents production code refactoring
  • Feature: represents a new feature
  • Documentation: documentation changes (no production code change)
  • Chore: maintenance tasks (no production code change)
  • Style: styles updates (no production code change)
  • Test: all about tests: adding, refactoring tests (no production code change)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

Turn Health Route into object and remove redundant indirection
@seakayone seakayone marked this pull request as ready for review December 12, 2022 12:12
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 86.64% // Head: 86.68% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (6adba1e) compared to base (cedb603).
Patch coverage: 4.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2337      +/-   ##
+ Coverage   86.64%   86.68%   +0.03%     
  Files         251      250       -1     
  Lines       28266    28252      -14     
- Hits        24491    24490       -1     
+ Misses       3775     3762      -13     
Impacted Files Coverage Δ
.../org/knora/webapi/core/HttpServerWithZIOHttp.scala 0.00% <0.00%> (ø)
.../knora/webapi/routing/HealthRouteWithZIOHttp.scala 0.00% <0.00%> (ø)
...ore/impl/TriplestoreServiceHttpConnectorImpl.scala 77.05% <0.00%> (ø) 100.00% <100.00%> (+15.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone merged commit 26e9596 into main Dec 12, 2022
11 checks passed
@seakayone seakayone deleted the wip/simplify-route-setup branch December 12, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants