Repository navigation
chore: Simplify layer setup for integration-tests and reduce to two layers - #2339
Conversation
Codecov ReportBase: 86.68% // Head: 86.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
==========================================
- Coverage 86.68% 86.48% -0.20%
==========================================
Files 250 257 +7
Lines 28252 28315 +63
==========================================
- Hits 24490 24488 -2
- Misses 3762 3827 +65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| type CommonR0 = ActorSystem with IIIFService with AppConfig | ||
| type CommonR = ApiRoutes |
There was a problem hiding this comment.
What does the CommonR0 and CommonR stand for? R is for "Routes", I guess? What about the 0? Could you write this explicitly? It would be clearer, I guess.
There was a problem hiding this comment.
The names for the parameters come from the signature of the function which uses it:
def makeSome[R0, R]. I am open for suggestions for a better naming.
Pull Request Checklist
Task Description/Number
Reduce the number of integration-test layers to two and extract common layers to a single
val.Issue Number: DEV-628
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?